[
https://issues.apache.org/jira/browse/FLINK-4564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15516429#comment-15516429
]
ASF GitHub Bot commented on FLINK-4564:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2517#discussion_r80240603
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistry.java
---
@@ -219,9 +235,19 @@ public ScopeFormats getScopeFormats() {
public void register(Metric metric, String metricName, MetricGroup
group) {
try {
if (reporters != null) {
- for (MetricReporter reporter : reporters) {
- if (reporter != null) {
-
reporter.notifyOfAddedMetric(metric, metricName, group);
+ for (int i= 0; i<reporters.size();i++) {
+ MetricReporter reporter =
reporters.get(i);
+ if (reporter != null){
+
+ FrontMetricGroup front;
+ try {
+ front= groups.get(i);
+ } catch
(IndexOutOfBoundsException e){
+ front=new
FrontMetricGroup(groups.size());
--- End diff --
it would be better to create these groups when the reporter is instantiated.
> [metrics] Delimiter should be configured per reporter
> -----------------------------------------------------
>
> Key: FLINK-4564
> URL: https://issues.apache.org/jira/browse/FLINK-4564
> Project: Flink
> Issue Type: Bug
> Components: Metrics
> Affects Versions: 1.1.0
> Reporter: Chesnay Schepler
> Assignee: Anton Mushin
>
> Currently, the delimiter used or the scope string is based on a configuration
> setting shared by all reporters. However, different reporters may have
> different requirements in regards to the delimiter, as such we should allow
> reporters to use a different delimiter.
> We can keep the current setting as a global setting that is used if no
> specific setting was set.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
