[ 
https://issues.apache.org/jira/browse/FLINK-4549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15516448#comment-15516448
 ] 

ASF GitHub Bot commented on FLINK-4549:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2500#discussion_r80237743
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenerator.scala
 ---
    @@ -545,7 +545,9 @@ class CodeGenerator(
         generateInputAccess(input._1, input._2, index)
       }
     
    -  override def visitFieldAccess(rexFieldAccess: RexFieldAccess): 
GeneratedExpression = ???
    +  override def visitFieldAccess(rexFieldAccess: RexFieldAccess): 
GeneratedExpression =
    +    throw new CodeGenException("The 'FieldAccess' feature is currently not 
supported.")
    --- End diff --
    
    This error message might not be very helpful. It does not tell a user what 
caused the problem and how it can be fixed. Would `"Nested field access is not 
support yet"` be better?


> Test and document implicitly supported SQL functions
> ----------------------------------------------------
>
>                 Key: FLINK-4549
>                 URL: https://issues.apache.org/jira/browse/FLINK-4549
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>            Reporter: Timo Walther
>            Assignee: Timo Walther
>
> Calcite supports many SQL functions by translating them into {{RexNode}} s. 
> However, SQL functions like {{NULLIF}}, {{OVERLAPS}} are neither tested nor 
> document although supported.
> These functions should be tested and added to the documentation. We could 
> adopt parts from the Calcite documentation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to