gyfora commented on code in PR #403:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/403#discussion_r996327566
##########
flink-kubernetes-standalone/src/main/java/org/apache/flink/kubernetes/operator/kubeclient/decorators/CmdStandaloneJobManagerDecorator.java:
##########
@@ -80,9 +80,14 @@ private List<String> getApplicationClusterArgs() {
}
Boolean allowNonRestoredState =
kubernetesJobManagerParameters.getAllowNonRestoredState();
- if (allowNonRestoredState != null) {
+ if (allowNonRestoredState != null && allowNonRestoredState) {
args.add("--allowNonRestoredState");
- args.add(allowNonRestoredState.toString());
+ }
+
+ String savepointPath =
kubernetesJobManagerParameters.getSavepointPath();
+ if (savepointPath != null) {
+ args.add("--fromSavepoint");
+ args.add(savepointPath);
Review Comment:
As we discussed on Slack, before this fix. Both `initialSavepoint` and
savepoint upgrade logic worked correctly so there must not really be a need for
the `--fromSavepoint` argument
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
