Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2504#discussion_r80258489
  
    --- Diff: 
flink-libraries/flink-table/src/test/resources/log4j-test.properties ---
    @@ -0,0 +1,27 @@
    
+################################################################################
    +#  Licensed to the Apache Software Foundation (ASF) under one
    +#  or more contributor license agreements.  See the NOTICE file
    +#  distributed with this work for additional information
    +#  regarding copyright ownership.  The ASF licenses this file
    +#  to you under the Apache License, Version 2.0 (the
    +#  "License"); you may not use this file except in compliance
    +#  with the License.  You may obtain a copy of the License at
    +#
    +#      http://www.apache.org/licenses/LICENSE-2.0
    +#
    +#  Unless required by applicable law or agreed to in writing, software
    +#  distributed under the License is distributed on an "AS IS" BASIS,
    +#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +#  See the License for the specific language governing permissions and
    +# limitations under the License.
    
+################################################################################
    +
    +# Set root logger level to OFF to not flood build logs
    +# set manually to INFO for debugging purposes
    +log4j.rootLogger=OFF, testlogger
    --- End diff --
    
    As I explained in my PR description: "This PR fixes the estimated costs for 
minus and union DataSet RelNodes". This was the root cause for the failing 
Calcite assumptions. I just added the log4j file to easily enable assertions in 
future.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to