[
https://issues.apache.org/jira/browse/FLINK-4590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15516635#comment-15516635
]
ASF GitHub Bot commented on FLINK-4590:
---------------------------------------
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/2504#discussion_r80258489
--- Diff:
flink-libraries/flink-table/src/test/resources/log4j-test.properties ---
@@ -0,0 +1,27 @@
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+
+# Set root logger level to OFF to not flood build logs
+# set manually to INFO for debugging purposes
+log4j.rootLogger=OFF, testlogger
--- End diff --
As I explained in my PR description: "This PR fixes the estimated costs for
minus and union DataSet RelNodes". This was the root cause for the failing
Calcite assumptions. I just added the log4j file to easily enable assertions in
future.
> Some Table API tests are failing when debug lvl is set to DEBUG
> ---------------------------------------------------------------
>
> Key: FLINK-4590
> URL: https://issues.apache.org/jira/browse/FLINK-4590
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
> Affects Versions: 1.2.0
> Reporter: Robert Metzger
> Assignee: Timo Walther
>
> For debugging another issue, I've set the log level on travis to DEBUG.
> After that, the Table API tests started failing
> {code}
> Failed tests:
> SetOperatorsITCase.testMinusAll:156 Internal error: Error occurred while
> applying rule DataSetScanRule
> SetOperatorsITCase.testMinusAll:156 Internal error: Error occurred while
> applying rule DataSetScanRule
> SetOperatorsITCase.testMinusAll:156 Internal error: Error occurred while
> applying rule DataSetScanRule
> SetOperatorsITCase.testMinusAll:156 Internal error: Error occurred while
> applying rule DataSetScanRule
> SetOperatorsITCase.testMinusDifferentFieldNames:204 Internal error: Error
> occurred while applying rule DataSetScanRule
> SetOperatorsITCase.testMinusDifferentFieldNames:204 Internal error: Error
> occurred while applying rule DataSetScanRule
> SetOperatorsITCase.testMinusDifferentFieldNames:204 Internal error: Error
> occurred while applying rule DataSetScanRule
> SetOperatorsITCase.testMinusDifferentFieldNames:204 Internal error: Error
> occurred while applying rule DataSetScanRule
> SetOperatorsITCase.testMinus:175 Internal error: Error occurred while
> applying rule DataSetScanRule
> SetOperatorsITCase.testMinus:175 Internal error: Error occurred while
> applying rule DataSetScanRule
> SetOperatorsITCase.testMinus:175 Internal error: Error occurred while
> applying rule DataSetScanRule
> SetOperatorsITCase.testMinus:175 Internal error: Error occurred while
> applying rule DataSetScanRule
> {code}
> Probably Calcite is executing additional assertions depending on the debug
> level.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
