[GitHub] [flink] XComp commented on a diff in pull request #18927: [FLINK-26390] Use try resourses for CliClient#executeFile

[GitBox]

XComp commented on code in PR #18927:
URL: https://github.com/apache/flink/pull/18927#discussion_r999053030


##########
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java:
##########
@@ -702,14 +698,14 @@ private void closeTerminal() {
         }
     }
 
-    private LineReader createLineReader(Terminal terminal) {
+    private LineReader createLineReader(Terminal terminal, Completer 
completer) {

Review Comment:
   ```suggestion
       private LineReader createLineReader(Terminal terminal, @Nullable 
Completer completer) {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org