[
https://issues.apache.org/jira/browse/FLINK-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15522615#comment-15522615
]
Till Rohrmann commented on FLINK-4596:
--------------------------------------
Hi [~nguraja], you're right that the class loading will fail due to the lower
casing of the restart strategy. This is clearly a bug and I'll fix it.
At the moment, the restart strategies are not intended to be pluggable. That's
also why you are not allowed create you own {{RestartStrategyConfigurations}}.
A problem, for example, is that the default restart strategy will be created
when you start the job manager. Thus, there won't be any user code classes
around. If you want to use this, then you would have to put the custom restart
strategy manually in the classpath of the {{JobManager}}.
If you need custom restart strategies, then we can change this restriction. We
could then introduce a {{CustomRestartStrategyConfiguration}} interface which
is capable to instantiate {{RestartStrategies}}. However, this class would have
to be serializable.
> RESTART_STRATEGY is not really pluggable
> ----------------------------------------
>
> Key: FLINK-4596
> URL: https://issues.apache.org/jira/browse/FLINK-4596
> Project: Flink
> Issue Type: Bug
> Reporter: Nagarjun Guraja
>
> Standalone cluster config accepts an implementation(class) as part of the
> yaml config file but that does not work either as cluster level restart
> strategy or streaming job level restart strategy
> CLUSTER LEVEL CAUSE: createRestartStrategyFactory converts configured value
> of strategyname to lowercase and searches for class name using lowercased
> string.
> JOB LEVEL CAUSE: Checkpointed streams have specific code to add
> fixeddelayrestartconfiguration if no RestartConfiguration is specified in
> the job env. Also, jobs cannot provide their own custom restart strategy
> implementation and are constrained to pick up one of the three restart
> strategies provided by flink.
> FIX: Do not lower case the strategy config value, support a new
> restartconfiguration to fallback to cluster level restart strategy and
> support jobs to provide custom implementation of the strategy class itself.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
