zentol commented on code in PR #21049: URL: https://github.com/apache/flink/pull/21049#discussion_r1000737949
##########
flink-rpc/flink-rpc-akka/pom.xml:
##########
@@ -195,6 +201,17 @@ under the License.
<exclude>META-INF/NOTICE.txt</exclude>
</excludes>
</filter>
+ <filter>
+
<artifact>*:*</artifact>
+
<excludes>
+
<!-- Only some of these licenses actually apply to the JAR and have been
manually
+
placed in this module's resources directory. -->
+
<exclude>LICENSE</exclude>
+
<!-- Only parts of NOTICE file actually apply to the netty JAR and have been
manually
+
copied into this modules's NOTICE file. -->
+
<exclude>NOTICE</exclude>
+
</excludes>
Review Comment:
We shouldn't apply such a blanket filter, but scope it to specific
dependencies.
Did you check the NOTICE/LICENSE contents for whether everything applicable
is replicated in our license files?
##########
flink-rpc/flink-rpc-akka/pom.xml:
##########
@@ -195,6 +201,17 @@ under the License.
<exclude>META-INF/NOTICE.txt</exclude>
</excludes>
</filter>
+ <filter>
+
<artifact>*:*</artifact>
+
<excludes>
+
<!-- Only some of these licenses actually apply to the JAR and have been
manually
+
placed in this module's resources directory. -->
+
<exclude>LICENSE</exclude>
+
<!-- Only parts of NOTICE file actually apply to the netty JAR and have been
manually
+
copied into this modules's NOTICE file. -->
+
<exclude>NOTICE</exclude>
+
</excludes>
Review Comment:
We shouldn't apply such a generic filter, but scope it to specific
dependencies.
Did you check the NOTICE/LICENSE contents for whether everything applicable
is replicated in our license files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
