[ https://issues.apache.org/jira/browse/FLINK-4564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15523160#comment-15523160 ]
ASF GitHub Bot commented on FLINK-4564: --------------------------------------- Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2517#discussion_r80479173 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistry.java --- @@ -219,9 +249,16 @@ public ScopeFormats getScopeFormats() { public void register(Metric metric, String metricName, MetricGroup group) { try { if (reporters != null) { - for (MetricReporter reporter : reporters) { + for (int i = 0; i < reporters.size(); i++) { + MetricReporter reporter = reporters.get(i); if (reporter != null) { - reporter.notifyOfAddedMetric(metric, metricName, group); + if (group instanceof AbstractMetricGroup) { + FrontMetricGroup front = groups.get(i); --- End diff -- just realized that we can simplify this. We don't need multiple FrontMetricGroups, but only 1 on which we also set the index before notify(). > [metrics] Delimiter should be configured per reporter > ----------------------------------------------------- > > Key: FLINK-4564 > URL: https://issues.apache.org/jira/browse/FLINK-4564 > Project: Flink > Issue Type: Bug > Components: Metrics > Affects Versions: 1.1.0 > Reporter: Chesnay Schepler > Assignee: Anton Mushin > > Currently, the delimiter used or the scope string is based on a configuration > setting shared by all reporters. However, different reporters may have > different requirements in regards to the delimiter, as such we should allow > reporters to use a different delimiter. > We can keep the current setting as a global setting that is used if no > specific setting was set. -- This message was sent by Atlassian JIRA (v6.3.4#6332)