[
https://issues.apache.org/jira/browse/FLINK-3734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15526303#comment-15526303
]
ASF GitHub Bot commented on FLINK-3734:
---------------------------------------
Github user lw-lin commented on a diff in the pull request:
https://github.com/apache/flink/pull/2557#discussion_r80704455
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
---
@@ -568,8 +568,8 @@ public void
setInitialState(ChainedStateHandle<StreamStateHandle> chainedState,
private void restoreState() throws Exception {
final StreamOperator<?>[] allOperators =
operatorChain.getAllOperators();
- try {
- if (lazyRestoreChainedOperatorState != null) {
+ if (lazyRestoreChainedOperatorState != null) {
--- End diff --
this `if (lazyRestoreChainedOperatorState != null)` check was moved out of
the `try` block because the same check is required in the `finally` block
> Unclosed DataInputView in
> AbstractAlignedProcessingTimeWindowOperator#restoreState()
> ------------------------------------------------------------------------------------
>
> Key: FLINK-3734
> URL: https://issues.apache.org/jira/browse/FLINK-3734
> Project: Flink
> Issue Type: Bug
> Reporter: Ted Yu
> Priority: Minor
>
> {code}
> DataInputView in = inputState.getState(getUserCodeClassloader());
> final long nextEvaluationTime = in.readLong();
> final long nextSlideTime = in.readLong();
> AbstractKeyedTimePanes<IN, KEY, STATE, OUT> panes =
> createPanes(keySelector, function);
> panes.readFromInput(in, keySerializer, stateTypeSerializer);
> restoredState = new RestoredState<>(panes, nextEvaluationTime,
> nextSlideTime);
> }
> {code}
> DataInputView in is not closed upon return.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
