[ 
https://issues.apache.org/jira/browse/FLINK-4657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15526753#comment-15526753
 ] 

ASF GitHub Bot commented on FLINK-4657:
---------------------------------------

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2550#discussion_r80733924
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java 
---
    @@ -467,6 +487,128 @@ public void registerAtResourceManager(final String 
address) {
                //TODO:: register at the RM
        }
     
    +   @RpcMethod
    +   public NextInputSplit requestNextInputSplit(final JobVertexID vertexID, 
final ExecutionAttemptID executionAttempt) {
    +           final byte[] serializedInputSplit;
    +
    +           final Execution execution = 
executionGraph.getRegisteredExecutions().get(executionAttempt);
    +           if (execution == null) {
    +                   log.error("Can not find Execution for attempt {}.", 
executionAttempt);
    --- End diff --
    
    The log could be on "debug" level, as this situation can occur when the 
JobManager failed tasks and unregistered them, but the cancel() messages have 
not reached the TaskManager.
    
    Since this is a valid situation, it should not cause a "WARN" message. In 
general, all situations that are valid race conditions and that need not 
indicate a corrupted state or lead to a failure / recovery should probably not 
have a "WARN" level.


> Implement HighAvailabilityServices based on zookeeper
> -----------------------------------------------------
>
>                 Key: FLINK-4657
>                 URL: https://issues.apache.org/jira/browse/FLINK-4657
>             Project: Flink
>          Issue Type: New Feature
>          Components: Cluster Management
>            Reporter: Kurt Young
>            Assignee: Kurt Young
>
> For flip-6, we will have ResourceManager and every JobManager as potential 
> leader contender and retriever. We should separate them by using different 
> zookeeper path. 
> For example, the path could be /leader/resource-manaeger for RM. And for each 
> JM, the path could be /leader/job-managers/JobID



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to