snuyanzin commented on code in PR #21203: URL: https://github.com/apache/flink/pull/21203#discussion_r1015947724
########## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/AbstractCodeGeneratorCastRule.java: ########## @@ -204,9 +204,10 @@ public String getSessionTimeZoneTerm() { } @Override - public String declareVariable(String type, String variablePrefix) { + public String declareVariable(String type, String variablePrefix, String defaultValue) { Review Comment: yes that's possible. However it's not only change in pom, after https://issues.apache.org/jira/browse/CALCITE-3745 it uses new api for compiler factory initialization. To use Janino 3.0.11 need to rollback this (includes Calcite's `EnumerableInterpretable.java`,`JaninoRexCompiler.java`, `JaninoRelMetadataProvider.java`, `JaninoCompiler.java`, after movement to 3.1.9 these classes will be removed) the commit will look like https://github.com/snuyanzin/flink/commit/0fd02d8ab9ac589b8d1bab9b92740bba193a2bed and other 3 commits from this PR workarounding janino's issues could be dropped then -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org