XComp commented on code in PR #20755:
URL: https://github.com/apache/flink/pull/20755#discussion_r1016424849
##########
flink-formats/flink-hadoop-bulk/src/test/java/org/apache/flink/formats/hadoop/bulk/HadoopPathBasedPartFileWriterTest.java:
##########
@@ -70,6 +70,7 @@ public void testPendingFileRecoverableSerializer() throws
IOException {
@Test
public void testWriteFile() throws Exception {
+ // create a tmp folder with random name using jdk file api
Review Comment:
I'm curious what the intention of this comment is: Doesn't it just describes
what the next line does? It feels a bit obsolete. WDYT?
##########
flink-formats/flink-hadoop-bulk/src/test/java/org/apache/flink/formats/hadoop/bulk/HadoopPathBasedPartFileWriterTest.java:
##########
@@ -82,13 +83,13 @@ public void testWriteFile() throws Exception {
DataStream<String> stream =
env.addSource(new FiniteTestSource<>(data),
TypeInformation.of(String.class));
Configuration configuration = new Configuration();
-
+ // Use day format , in case of this test case run across two hours
Review Comment:
That's a more reasonable comment - but I would argue that the fix is still
not good enough in that case. What if the test runs at midnight? We would still
have the same issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
