RyanSkraba commented on code in PR #19897:
URL: https://github.com/apache/flink/pull/19897#discussion_r1019286172
##########
flink-formats/flink-csv/src/test/java/org/apache/flink/formats/csv/CsvFormatFilesystemStatisticsReportTest.java:
##########
@@ -34,16 +34,16 @@
/**
* Test for statistics functionality in {@link CsvFormatFactory} in the case
of file system source.
*/
-public class CsvFormatFilesystemStatisticsReportTest extends
CsvFormatStatisticsReportTest {
+class CsvFormatFilesystemStatisticsReportTest extends
CsvFormatStatisticsReportTest {
+ @Override
@BeforeEach
public void setup(@TempDir File file) throws Exception {
Review Comment:
I guess this is true, but I'd prefer to avoid `@VisibleForTesting` for
classes in the `src/test/java` hierarchy... There are a few places in the Flink
code where I've seen this, but it's pretty rare and probably not what the
contributor really intended!
~I'll change it to protected.~ Sorry, I misread -- this can't be changed to
protected without changing the entire hierarchy of tests that depend on it
across many modules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
