tsreaper commented on code in PR #369: URL: https://github.com/apache/flink-table-store/pull/369#discussion_r1019776118
########## docs/content/docs/filesystem/overview.md: ########## @@ -0,0 +1,91 @@ +--- +title: "Overview" +weight: 1 +type: docs +aliases: +- /filesystem/overview.html +--- +<!-- +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +--> + +# Overview + +# File Systems for Unified Engine + +Apache Flink Table Store utilizes the same pluggable file systems as Apache Flink. Users can follow the [standard plugin mechanism](https://nightlies.apache.org/flink/flink-docs-release-1.16/docs/deployment/filesystems/plugins/) to configure the Review Comment: Use https://nightlies.apache.org/flink/flink-docs-stable/docs/deployment/filesystems/plugins/ , don't use a specific version. ########## flink-table-store-spark2/src/main/java/org/apache/flink/table/store/spark/SparkSource.java: ########## @@ -19,21 +19,25 @@ package org.apache.flink.table.store.spark; import org.apache.flink.configuration.Configuration; +import org.apache.flink.core.fs.FileSystem; import org.apache.flink.table.store.table.FileStoreTableFactory; import org.apache.spark.sql.sources.DataSourceRegister; import org.apache.spark.sql.sources.v2.DataSourceOptions; import org.apache.spark.sql.sources.v2.ReadSupport; +import org.apache.spark.sql.sources.v2.SessionConfigSupport; import org.apache.spark.sql.sources.v2.reader.DataSourceReader; import org.apache.spark.sql.types.StructType; /** The Spark source for table store. */ -public class SparkSource implements DataSourceRegister, ReadSupport { +public class SparkSource implements DataSourceRegister, ReadSupport, SessionConfigSupport { + + private static final String SHORT_NAME = "tablestore"; @Override public String shortName() { // Not use 'table-store' here, the '-' is not allowed in SQL - return "tablestore"; + return SHORT_NAME; Review Comment: Same above. ########## flink-table-store-spark/src/main/java/org/apache/flink/table/store/spark/SparkSource.java: ########## @@ -31,12 +32,14 @@ import java.util.Map; /** The spark source for table store. */ -public class SparkSource implements DataSourceRegister, TableProvider { +public class SparkSource implements DataSourceRegister, SessionConfigSupport { + + private static final String SHORT_NAME = "tablestore"; @Override public String shortName() { // Not use 'table-store' here, the '-' is not allowed in SQL Review Comment: Move comment above `private static final`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
