dingweiqings commented on code in PR #20755:
URL: https://github.com/apache/flink/pull/20755#discussion_r1019785021


##########
flink-formats/flink-hadoop-bulk/src/test/java/org/apache/flink/formats/hadoop/bulk/HadoopPathBasedPartFileWriterTest.java:
##########
@@ -82,13 +84,23 @@ public void testWriteFile() throws Exception {
         DataStream<String> stream =
                 env.addSource(new FiniteTestSource<>(data), 
TypeInformation.of(String.class));
         Configuration configuration = new Configuration();
-
+        // Elements from source  assign to one bucket , and produce two part 
after checkpoint.
         HadoopPathBasedBulkFormatBuilder<String, String, ?> builder =
                 new HadoopPathBasedBulkFormatBuilder<>(
                         basePath,
                         new TestHadoopPathBasedBulkWriterFactory(),
                         configuration,
-                        new DateTimeBucketAssigner<>());
+                        new BucketAssigner<String, String>() {

Review Comment:
   Yes , I think your idea is better . I push a new commit .



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to