jnh5y commented on code in PR #21133:
URL: https://github.com/apache/flink/pull/21133#discussion_r1021876246
##########
flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/SqlGatewayServiceImpl.java:
##########
@@ -79,6 +82,32 @@ public void closeSession(SessionHandle sessionHandle) throws
SqlGatewayException
}
}
+ @Override
+ public ResultSet configureSession(
+ SessionHandle sessionHandle, String statement, long
executionTimeoutMs)
+ throws SqlGatewayException {
+ try {
+ if (executionTimeoutMs > 0) {
+ // TODO: support the feature in FLINK-27838
+ throw new UnsupportedOperationException(
+ "SqlGatewayService doesn't support timeout mechanism
now.");
+ }
+ OperationHandle operationHandle =
+ getSession(sessionHandle)
+ .getOperationManager()
+ .submitOperation(
+ handle ->
+ getSession(sessionHandle)
+ .createExecutor()
+ .configureSession(handle,
statement));
+ return fetchConfigureSessionResult(sessionHandle, operationHandle);
Review Comment:
Are there any concurrency concerns here?
I'm new to the codebase; seems like it ought to be ok, but figured I'd ask.
To validate what I understand so far, I'm guessing that the SQL client will
block on getting a response back. Also, it looks like the
`fetchConfigureSessionResult` will block on getting the result back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
