[GitHub] [flink] Myasuka commented on a diff in pull request #21281: [FLINK-29969][checkpoint] Show the root cause when exceeded checkpoint tolerable failure threshold

[GitBox]

Myasuka commented on code in PR #21281:
URL: https://github.com/apache/flink/pull/21281#discussion_r1023930513


##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointFailureManager.java:
##########
@@ -204,7 +204,8 @@ private void checkFailureAgainstCounter(
             if (continuousFailureCounter.get() > tolerableCpFailureNumber) {
                 clearCount();
                 errorHandler.accept(
-                        new 
FlinkRuntimeException(EXCEEDED_CHECKPOINT_TOLERABLE_FAILURE_MESSAGE));
+                        new FlinkRuntimeException(
+                                EXCEEDED_CHECKPOINT_TOLERABLE_FAILURE_MESSAGE, 
exception));

Review Comment:
   I think this might be a better idea. BTW, could you please make `Exceeded 
checkpoint tolerable failure threshold` ends with a period instead of a comma 
to make it the same as before.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org