morhidi commented on code in PR #420:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/420#discussion_r1024158133
##########
flink-kubernetes-webhook/pom.xml:
##########
@@ -96,6 +96,12 @@ under the License.
<version>${okhttp.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.mockito</groupId>
Review Comment:
Ah ok, I didn't realize there's `TestUtils.setEnv(Map<String, String>
newEnv)`, yes you can use that.
##########
flink-kubernetes-webhook/pom.xml:
##########
@@ -96,6 +96,12 @@ under the License.
<version>${okhttp.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.mockito</groupId>
Review Comment:
@gyfora what do you think? Shall we lift the 'mockito' restriction? It's
quite convenient to use the EnvUtil how it is implemented today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
