Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2559#discussion_r81089161
--- Diff:
flink-streaming-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/Kafka09Fetcher.java
---
@@ -301,4 +316,16 @@ public void
commitSpecificOffsetsToKafka(Map<KafkaTopicPartition, Long> offsets)
}
return result;
}
+
+ private class CommitCallback implements OffsetCommitCallback {
+
+ @Override
+ public void onComplete(Map<TopicPartition, OffsetAndMetadata>
offsets, Exception exception) {
+ commitInProgress = false;
+
+ if (exception != null) {
+ LOG.warn("Committing offsets to Kafka failed.
This does not compromise Flink's checkpoints", exception);
--- End diff --
Oops, this is actually correct, sorry.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
