reta commented on code in PR #1:
URL:
https://github.com/apache/flink-connector-opensearch/pull/1#discussion_r1028121584
##########
pom.xml:
##########
@@ -327,6 +327,12 @@ under the License.
</dependency>
<!-- For dependency convergence -->
+ <dependency>
+ <groupId>net.java.dev.jna</groupId>
+ <artifactId>jna</artifactId>
Review Comment:
> So could we exclude it in general? Or do we need it for some tests to work?
I believe tests may need it, it is still required dependency by and large
(unless repacked).
> What is the bootstrap licensing issue about?
Not sure this is license, the packaging is mirroring the Elasticsearch
Connector [1], in this particular case following its conventions (or issues
discovered in the past?)
[1]
https://github.com/apache/flink-connector-elasticsearch/blob/main/flink-sql-connector-elasticsearch7/pom.xml#L93
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
