echauchot commented on PR #1: URL: https://github.com/apache/flink-connector-cassandra/pull/1#issuecomment-1323381672
> > > > We'd like to preserve the git history; can you integrate the `cas_rewrite` branch from this repo into your PR? > > > > > > > > > That makes total sense. I'll rebase on the branch. IMHO it would be interesting to add an item to your migration doc to inform contributors to keep history, that way you would not need to create the branch yourself. > > > > > > @zentol: I rebased on cas_rerewrite and when I pushed to my fork it has closed the PR automatically with no action from my side. I don't have the rights to re-open it. Could you reopen this PR so that we don't lose your review comments? > > I messed up the rebase. I needed to rebase the other way around > > @zentol I've fixed my rebase, do you prefer that you reopen this PR and I force push here or that I open another PR ? I opened a new one: https://github.com/apache/flink-connector-cassandra/pull/2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
