[GitHub] [flink] lincoln-lil commented on a diff in pull request #20745: [FLINK-28988] Don't push filters down into the right table for temporal join

[GitBox]

lincoln-lil commented on code in PR #20745:
URL: https://github.com/apache/flink/pull/20745#discussion_r1030076295


##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/FlinkFilterJoinRule.java:
##########
@@ -128,7 +129,9 @@ protected void perform(RelOptRuleCall call, Filter filter, 
Join join) {
                 joinType,
                 true,
                 !joinType.generatesNullsOnLeft(),
-                !joinType.generatesNullsOnRight(),
+                !joinType.generatesNullsOnRight()
+                        && 
!TemporalJoinUtil.containsInitialTemporalJoinCondition(

Review Comment:
   I think we can only deal with the event time temporal join since processing 
time temporal join is unsupported for now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org