JingsongLi commented on code in PR #395:
URL: https://github.com/apache/flink-table-store/pull/395#discussion_r1030087733


##########
flink-table-store-connector/src/test/java/org/apache/flink/table/store/connector/PartialUpdateITCase.java:
##########
@@ -65,8 +65,10 @@ public void testMergeRead() {
         batchSql("INSERT INTO T VALUES (1, 2, 4, 5, CAST(NULL AS STRING))");
         batchSql("INSERT INTO T VALUES (1, 2, 4, CAST(NULL AS INT), '6')");
 
-        List<Row> result = batchSql("SELECT * FROM T");
-        assertThat(result).containsExactlyInAnyOrder(Row.of(1, 2, 4, 5, "6"));
+        assertThat(batchSql("SELECT * FROM 
T")).containsExactlyInAnyOrder(Row.of(1, 2, 4, 5, "6"));
+
+        // projection
+        assertThat(batchSql("SELECT a FROM 
T")).containsExactlyInAnyOrder(Row.of(4));

Review Comment:
   At present, we do not support nested pushdowns, so there is no difference 
between array maps and ordinary fields.



##########
flink-table-store-connector/src/test/java/org/apache/flink/table/store/connector/PreAggregationITCase.java:
##########
@@ -711,6 +710,10 @@ public void testMergeInMemory() {
                                     (long) 10101000,
                                     (float) 0,
                                     1.11));
+
+            // projection
+            assertThat(batchSql("SELECT f,e FROM T1"))

Review Comment:
   Ditto.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to