zentol commented on code in PR #1:
URL:
https://github.com/apache/flink-connector-opensearch/pull/1#discussion_r1030595354
##########
flink-connector-opensearch/src/main/java/org/apache/flink/connector/opensearch/sink/OpensearchSink.java:
##########
@@ -88,4 +88,8 @@ public SinkWriter<IN> createWriter(InitContext context)
throws IOException {
context.metricGroup(),
context.getMailboxExecutor());
}
+
+ DeliveryGuarantee getDeliveryGuarantee() {
Review Comment:
The architecture tests verify that these methods are only called in tests ;)
It allows us to leak some implementation details into tests without impacting
production code. Can make your life a lot easier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
