snuyanzin commented on code in PR #21368:
URL: https://github.com/apache/flink/pull/21368#discussion_r1031187786


##########
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/channel/ChannelStateWriteRequestDispatcherImplTest.java:
##########
@@ -68,16 +67,16 @@ public void testConcurrentUnalignedCheckpoint() throws 
Exception {
         processor.dispatch(
                 ChannelStateWriteRequest.start(
                         1L, result, 
CheckpointStorageLocationReference.getDefault()));
-        assertFalse(result.isDone());
+        assertThat(result.isDone()).isFalse();
 
         processor.dispatch(
                 ChannelStateWriteRequest.start(
                         2L,
                         new ChannelStateWriteResult(),
                         CheckpointStorageLocationReference.getDefault()));
-        assertTrue(result.isDone());
-        
assertTrue(result.getInputChannelStateHandles().isCompletedExceptionally());
-        
assertTrue(result.getResultSubpartitionStateHandles().isCompletedExceptionally());
+        assertThat(result.isDone()).isTrue();
+        
assertThat(result.getInputChannelStateHandles().isCompletedExceptionally()).isTrue();
+        
assertThat(result.getResultSubpartitionStateHandles().isCompletedExceptionally()).isTrue();

Review Comment:
   ```suggestion
           
assertThat(result.getInputChannelStateHandles()).isCompletedExceptionally();
           
assertThat(result.getResultSubpartitionStateHandles()).isCompletedExceptionally();
   ```
   assertj supports some `CompletableFuture` methods



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to