hdulay commented on code in PR #21436:
URL: https://github.com/apache/flink/pull/21436#discussion_r1039021869
##########
flink-formats/flink-protobuf/src/test/java/org/apache/flink/formats/protobuf/Pb3ToRowTest.java:
##########
@@ -85,6 +88,8 @@ public void testDeserialization() throws Exception {
assertEquals(1, rowData.getInt(0));
assertEquals(2L, rowData.getLong(1));
+
+ assertEquals(ts.getNanos(), row.getTimestamp(11,
3).getNanoOfMillisecond());
Review Comment:
@MartijnVisser Hi. I'm suggesting to add support for 3rd party protobuf
datatype. Which needs a mapping to either a RowType or a SimpleType in the
protobuf codegen components. I'm assuming this is the correct approach. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
