SmirAlex commented on PR #20919: URL: https://github.com/apache/flink/pull/20919#issuecomment-1340494991
Hi @XComp @zentol, thanks for your careful review! I took into account all your comments and created a commit with following changes: - Now `CacheLoader` returns future directly in method `CacheLoader#reloadAsync()`. As a consequence `CacheLoader` has direct control over the thread which executes cache reload operation. - I no more rely on common ForkJoinPool. `CacheLoader` creates `Executors.newSingleThreadExecutor()` in `#open` method that is responsible for the whole reload operation. - Now `CacheLoader` can directly shutdown its executor in `#close`, so I decided to remove close mechanism based on boolean variable checking and keep only the one based on thread interruption. Therefore logic became more clear and straightforward. So now there is only one test on `CacheLoader#close` - Now `InputFormatCacheLoader` executes one load task in main reload thread (in `Cacheloader#reloadExecutor`), so we are saving on creating additional thread for reading from input split. - Improved logging on `CacheLoader#close` a little bit Please take a look on the latest commit when you will be available, looking forward for your review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
