ottomata opened a new pull request, #478: URL: https://github.com/apache/flink-kubernetes-operator/pull/478
When mounted volumes use subPath, the volume that uses them is not updated automatically. So, even you do update the ConfigMap in k8s, the flink-conf.yaml file will never see those updates. All of the entires in the flink-operator-config-volume configMap are mounted in each container anyway, so we might as well just mount the flink-operator-config-volume directly at /opt/flink/conf witihout specifying the subPath of each file. This allows for Dynamic Operator Configuration to work when deployed with these helm charts. https://nightlies.apache.org/flink/flink-kubernetes-operator-docs-main/docs/operations/configuration/#dynamic-operator-configuration <!-- *Thank you very much for contributing to the Apache Flink Kubernetes Operator - we are happy that you want to help us improve the project. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.* ## Contribution Checklist - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue. - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component. Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix][docs] Fix typo in event time introduction` or `[hotfix][javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`. - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review. - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can read more on how we use GitHub Actions for CI [here](https://nightlies.apache.org/flink/flink-kubernetes-operator-docs-main/docs/development/guide/#cicd). - Each pull request should address only one issue, not mix up code from multiple issues. - Each commit in the pull request has a meaningful commit message (including the JIRA id) - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below. **(The sections below can be removed for hotfixes of typos)** --> ## What is the purpose of the change This pull request allows flink-kubernetes-operators deployed with the built in helm chart to work with Dynamic Operator Configuration. ## Brief change log - Mount flink-operator-config-volume directly at /opt/flink/conf without using `subPath` ## Verifying this change <!-- Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing --> This change added tests and can be verified as follows: - Modiify the following in helm values.yaml: ```yaml watchNamespaces: ["flink-app0"] defaultConfiguration: create: true # Set append to false to replace configuration files append: true flink-conf.yaml: |+ # Enable dynamic reloading of watchNamespaces kubernetes.operator.dynamic.namespaces.enabled: true kubernetes.operator.dynamic.config.enabled: true kubernetes.operator.dynamic.config.check.interval: 10 s ``` - Install the flink-kubernetes-operator helm chart: `helm install flink-kubernetes-operator .` - After startup, edit the flink-operator-config ConfigMap and change the `watchNamespaces`: `kubectl edit configmap flink-operator-config` - Wait for > 10 s (see also https://kubernetes.io/docs/concepts/configuration/configmap/#mounted-configmaps-are-updated-automatically). - Tail flink-kubernetes-operator pod logs and see if it ever updates its watched namespaces. - Get a shell on the flink-kubernetes-operator container and examine /opt/flink/conf/flink-conf.yaml Without this change, flink-conf.yaml never changes. With this change, it does, and flink-kubernetes-operator discovers new namespaces to watch appropriately. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changes to the `CustomResourceDescriptors`: no - Core observer or reconciler logic that is regularly executed: / n ## Documentation - Does this pull request introduce a new feature? no -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
