snuyanzin commented on PR #21459: URL: https://github.com/apache/flink/pull/21459#issuecomment-1342207355
Thanks for the feedback. I updated the rest of `AggregateCall.create` and also updated some more deprecated methods (updated in description) `org.apache.calcite.rex.RexWindowBound#create`, `org.apache.calcite.rel.RelCollationImpl#of(org.apache.calcite.rel.RelFieldCollation...)` and `org.apache.calcite.rel.core.Window.RexWinAggCall#RexWinAggCall(SqlAggFunction, RelDataType, List<RexNode>, int, boolean)` About `RexSimplify` yes it should not be updated. It is a copy of Calcite's `RexSimplify` with one change in it and should be supported synced with Calcite's version while update. It should be removed once a corresponding jira issue will be fixed https://github.com/apache/flink/blob/e6215d4f7ede96f1225921f2b0f322c87a5040cd/flink-table/flink-table-planner/src/main/java/org/apache/calcite/rex/RexSimplify.java#L69-L73 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
