[ https://issues.apache.org/jira/browse/FLINK-30250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645055#comment-17645055 ]
Junhan Yang commented on FLINK-30250: ------------------------------------- [~fanrui] I left some comments in the PR :) > The flame graph type is wrong > ----------------------------- > > Key: FLINK-30250 > URL: https://issues.apache.org/jira/browse/FLINK-30250 > Project: Flink > Issue Type: Bug > Components: Runtime / REST, Runtime / Web Frontend > Affects Versions: 1.15.0, 1.16.0, 1.17.0 > Reporter: Rui Fan > Priority: Major > Labels: pull-request-available > Fix For: 1.17.0 > > Attachments: image-2022-11-30-19-08-42-067.png > > > When the flame graph type is switched from On-CPU to Mixed. It still show the > graph of On-CPU. > h2. Root cause: > When click the other types, the web frontend will call the requestFlameGraph > and update the graphType. However, the graphType is the old type during > requestFlameGraph. So the graph type show the new type, but the flame graph > is the result of old type. > [code link > |https://github.com/apache/flink/blob/8bbf52688758bbede45df060a4c11e5fa228b6f0/flink-runtime-web/web-dashboard/src/app/pages/job/overview/flamegraph/job-overview-drawer-flamegraph.component.ts#L82] > !image-2022-11-30-19-08-42-067.png|width=1026,height=389! -- This message was sent by Atlassian Jira (v8.20.10#820010)