[ 
https://issues.apache.org/jira/browse/FLINK-23408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645192#comment-17645192
 ] 

Dawid Wysakowicz commented on FLINK-23408:
------------------------------------------

I don't know where is this code coming from. As I said, in master both drain 
and w/o drain stops the source first: 
https://github.com/apache/flink/blob/d86ae5d642fa578fb85118e81dd4140d504f818a/flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SourceStreamTask.java#L260
 or 
https://github.com/apache/flink/blob/d86ae5d642fa578fb85118e81dd4140d504f818a/flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SourceOperatorStreamTask.java#L179

> Wait for a checkpoint completed after finishing a task
> ------------------------------------------------------
>
>                 Key: FLINK-23408
>                 URL: https://issues.apache.org/jira/browse/FLINK-23408
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Runtime / Checkpointing, Runtime / Task
>            Reporter: Dawid Wysakowicz
>            Assignee: Dawid Wysakowicz
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.14.0
>
>         Attachments: image-2022-12-09-16-53-08-286.png, 
> image-2022-12-09-16-54-05-453.png
>
>
> Before finishing a task we should wait for a checkpoint issued after 
> {{finish()}} to commit all pending transactions created from the {{finish()}} 
> method.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to