snuyanzin commented on code in PR #20991:
URL: https://github.com/apache/flink/pull/20991#discussion_r1047272272
##########
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducerBaseTest.java:
##########
@@ -219,7 +227,8 @@ public void testAsyncErrorRethrownOnCheckpoint() throws
Throwable {
* pending records. The test for that is covered in
testAtLeastOnceProducer.
*/
@SuppressWarnings("unchecked")
- @Test(timeout = 5000)
+ @Test
+ @Timeout(5L)
Review Comment:
time unit should be specified
##########
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducerBaseTest.java:
##########
@@ -280,7 +289,8 @@ public void go() throws Exception {
* the test will not finish if the logic is broken.
*/
@SuppressWarnings("unchecked")
- @Test(timeout = 10000)
+ @Test
+ @Timeout(10L)
Review Comment:
time unit should be specified
##########
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducerBaseTest.java:
##########
@@ -353,7 +363,8 @@ public void go() throws Exception {
* records; we set a timeout because the test will not finish if the logic
is broken.
*/
@SuppressWarnings("unchecked")
- @Test(timeout = 5000)
+ @Test
+ @Timeout(10L)
Review Comment:
time unit should be specified
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
