1996fanrui commented on code in PR #21443: URL: https://github.com/apache/flink/pull/21443#discussion_r1049789012
########## flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskTest.java: ########## @@ -1799,6 +1811,64 @@ public void testMailboxMetricsMeasurement() throws Exception { } } + @Test + public void testForwardPartitionerIsConvertedToRebalanceOnParallelismChanges() + throws Exception { + StreamTaskMailboxTestHarnessBuilder<Integer> builder = + new StreamTaskMailboxTestHarnessBuilder<>( + OneInputStreamTask::new, BasicTypeInfo.INT_TYPE_INFO) + .addInput(BasicTypeInfo.INT_TYPE_INFO) + .setOutputPartitioner(new ForwardPartitioner<>()) + .setupOutputForSingletonOperatorChain( + new TestBoundedOneInputStreamOperator()); + + try (StreamTaskMailboxTestHarness<Integer> harness = builder.build()) { + + RecordWriterDelegate<SerializationDelegate<StreamRecord<Object>>> recordWriterDelegate = + harness.streamTask.createRecordWriterDelegate( + harness.streamTask.configuration, harness.streamMockEnvironment); + // Prerequisite: We are using the ForwardPartitioner + assertTrue( + ((ChannelSelectorRecordWriter) + ((SingleRecordWriter) recordWriterDelegate) + .getRecordWriter(0)) + .getChannelSelector() + instanceof ForwardPartitioner); + + // Change consumer parallelism + harness.streamTask.configuration.setVertexNonChainedOutputs( + Arrays.asList( + new NonChainedOutput( + false, + 0, + // Set a different consumer parallelism to force trigger + // replacing the ForwardPartitioner + 42, + 100, + 1000, + false, + new IntermediateDataSetID(), + new OutputTag<>("output", IntegerTypeInfo.INT_TYPE_INFO), + // Use forward partitioner + new ForwardPartitioner<>(), + ResultPartitionType.PIPELINED))); + harness.streamTask.configuration.serializeAllConfigs(); + + // Re-create outputs + recordWriterDelegate = + harness.streamTask.createRecordWriterDelegate( + harness.streamTask.configuration, harness.streamMockEnvironment); + // We should now have a RescalePartitioner to distribute the load Review Comment: Hi @mxm , thanks for your update. Here is a minor comment. ```suggestion // We should now have a RebalancePartitioner to distribute the load ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org