xintongsong commented on code in PR #21419:
URL: https://github.com/apache/flink/pull/21419#discussion_r1053028752
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptivebatch/AdaptiveBatchScheduler.java:
##########
@@ -78,6 +79,8 @@ public class AdaptiveBatchScheduler extends DefaultScheduler {
private final Map<JobVertexID, ForwardGroup> forwardGroupsByJobVertexId;
+ private final boolean onlyConsumeFinishedPartition;
Review Comment:
Let's name this `hybridOnlyConsumeFinishedPartition`, to emphasize that this
only affects hybrid result partitions.
Same for the variables / fields in other classes.
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptivebatch/AdaptiveBatchSchedulerFactory.java:
##########
@@ -216,6 +224,13 @@ public SchedulerNG createInstance(
}
}
+ public static InputConsumableDecider.Factory
loadInputConsumableDeciderFactory(
+ boolean onlyConsumeFinishedPartition) {
+ return onlyConsumeFinishedPartition
+ ? AllFinishedInputConsumableDecider.Factory.INSTANCE
+ : DefaultInputConsumableDecider.Factory.INSTANCE;
Review Comment:
This is hard to understand, because the semantic of
`onlyConsumeFinishedPartition` and `AllFinishedInputConsumableDecider` are not
equivalent. I understand that this is an intermediate state, but we'd better to
explain it in comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
