liuml07 opened a new pull request, #21549:
URL: https://github.com/apache/flink/pull/21549

   ## What is the purpose of the change
   
   The file system SQL connector itself is included in Flink and does not 
require an additional dependency. However, if a user uses the filesystem 
connector for [local execution](< ref "docs/dev/dataset/local_execution" >),
   for e.g. running Flink job in the IDE, she will need to add dependency. 
Otherwise, the user will get validation exception: Cannot discover a connector 
using option: 'connector'='filesystem'. This is confusing and can be documented.
   
   ## Brief change log
   
   The scope of the files connector dependency should be provided, because they 
should not be packaged into the JAR file.
   So we did not use the `sql_download_table` shortcodes like `{{< 
sql_download_table "files" >}}`. Also that shortcodes has texts saying the 
dependencies are required for SQL Client with SQL JAR bundles. That is not 
applicable to files connector as it's already shipped int he `/lib` directlory.
   
   
   ## Verifying this change
   
   This is a doc change, and I have tested it rendered locally.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** 
/ don't know)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't 
know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / 
JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to