fsk119 commented on code in PR #21577:
URL: https://github.com/apache/flink/pull/21577#discussion_r1060260536
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/AlterSchemaConverter.java:
##########
@@ -698,7 +782,7 @@ private AlterSchemaStrategy
computeAlterSchemaStrategy(SqlAlterTableSchema alter
alterTableSchema.getClass().getCanonicalName()));
}
- private static <T> T unwrap(Optional<T> value) {
+ private <T> T unwrap(Optional<T> value) {
Review Comment:
ModifySchemaConverter and AddSchemaConverter are both static classes and can
only use static methods in the parent class. But now I change them to
class-level inner class, so I think we can remove the static keyword now.
BTW, I think we should narrow the scope of the visibility. With the `static`
keyword, the visibility is much larger. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
