yuchuanchen commented on code in PR #21563:
URL: https://github.com/apache/flink/pull/21563#discussion_r1060263636
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/PushProjectIntoTableSourceScanRule.java:
##########
@@ -186,11 +193,30 @@ private boolean supportsMetadata(DynamicTableSource
tableSource) {
return tableSource instanceof SupportsReadingMetadata;
}
- private boolean supportsNestedProjection(DynamicTableSource tableSource) {
+ private boolean supportsNestedProjection(
+ DynamicTableSource tableSource, LogicalProject project) {
+ List<RexNode> projects = project.getProjects();
return supportsProjectionPushDown(tableSource)
+ && isVectorizedSupportedTypes(projects)
&& ((SupportsProjectionPushDown)
tableSource).supportsNestedProjection();
}
+ private boolean isVectorizedSupportedTypes(List<RexNode> projects) {
Review Comment:
good idea, I will change it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
