swuferhong commented on code in PR #21586:
URL: https://github.com/apache/flink/pull/21586#discussion_r1066676100
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/batch/BatchPhysicalHashAggregate.scala:
##########
@@ -53,7 +53,8 @@ class BatchPhysicalHashAggregate(
grouping: Array[Int],
auxGrouping: Array[Int],
aggCallToAggFunction: Seq[(AggregateCall, UserDefinedFunction)],
- isMerge: Boolean)
+ isMerge: Boolean,
+ canProjection: Boolean)
Review Comment:
> For global hash agg, we don't need this variable, it should always be
false.
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
