[
https://issues.apache.org/jira/browse/FLINK-4730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551770#comment-15551770
]
ASF GitHub Bot commented on FLINK-4730:
---------------------------------------
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/2583#discussion_r82173351
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointMetaData.java
---
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.checkpoint;
+
+import org.apache.flink.util.Preconditions;
+
+import java.io.Serializable;
+
+/**
+ * Encapsulates all the meta data for a checkpoint.
+ */
+public class CheckpointMetaData implements Serializable {
--- End diff --
Yes, I separated the metrics from id and timestamp into a separate property
class.
> Introduce CheckpointMetaData
> ----------------------------
>
> Key: FLINK-4730
> URL: https://issues.apache.org/jira/browse/FLINK-4730
> Project: Flink
> Issue Type: Bug
> Components: State Backends, Checkpointing
> Reporter: Stefan Richter
> Assignee: Stefan Richter
>
> Currently, the meta data for each checkpoint consists of up to 5 long values
> which are passed through several functions. When adding/removing meta data
> we would have to change function signatures in many places. Furthermore, this
> is prone to errors when the order of arguments is changed accidentally. We
> should introduce a CheckpointMetaData which encapsulates this checkpoint meta
> data.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
