[
https://issues.apache.org/jira/browse/FLINK-4753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15551952#comment-15551952
]
ASF GitHub Bot commented on FLINK-4753:
---------------------------------------
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/2604
[FLINK-4753] [kafka] PeriodicOffsetCommitter should synchronize on
checkpoint lock
The `PeriodicOffsetCommitter` in Kafka 0.8 currently doesn't synchronize on
the checkpoint lock when creating a copy of the partition offsets in the
current state.
This change proposes to pass the checkpoint lock into
`PeriodicOffsetCommitter`, and let `PeriodicOffsetCommitter` use
`Kafka08Fetcher#snapshotCurrentState()` to make copies of the current state.
This PR also includes removal of some leftover unused code after some
recent refactoring of the Kafka connectors in commit 53ed6ada.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tzulitai/flink FLINK-4753
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2604.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2604
----
commit 90dfeed7a8b9898a57edfd0082e12b0711895280
Author: Tzu-Li (Gordon) Tai <tzuli...@apache.org>
Date: 2016-10-06T11:23:01Z
[FLINK-4753] [kafka] PeriodicOffsetCommitter should synchronize on
checkpoint lock
----
> Kafka 0.8 connector's Periodic Offset Committer should synchronize on
> checkpoint lock
> -------------------------------------------------------------------------------------
>
> Key: FLINK-4753
> URL: https://issues.apache.org/jira/browse/FLINK-4753
> Project: Flink
> Issue Type: Bug
> Components: Kafka Connector
> Reporter: Tzu-Li (Gordon) Tai
> Assignee: Tzu-Li (Gordon) Tai
> Fix For: 1.2.0
>
>
> The {{PeriodicOffsetCommitter}} doesn't synchronize on the checkpoint lock
> when creating a copy of the partition offsets in the current state.
> I propose to pass the checkpoint lock into{{PeriodicOffsetCommitter}}, and
> let {{PeriodicOffsetCommitter}} use {{Kafka08Fetcher#snapshotCurrentState()}}
> to make the current state copy.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
