Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/2588
  
    Looks good, thanks, will merge this.
    
    I would suggest two followups:
      - We can remove the "dispose savepoint" method, because that is 
functionality disappearing right now. Savepoints need no special remove logic 
any more, they are just a directory in a filesystem.
    
      - We can reduce the number of message classes (like 
`TriggerSavepointResponse`) by using exceptions more prominently. The 
"triggerSavepoint()" method could simply return a String (success) or throw an 
exception (failure). Exceptions are propagated by the RPC, so the caller future 
will always get it as a response.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to