Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2584#discussion_r82211497
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/savepoint/SavepointV1Serializer.java
 ---
    @@ -290,6 +290,7 @@ public static void 
serializeStreamStateHandle(StreamStateHandle stateHandle, Dat
                } else if (stateHandle instanceof ByteStreamStateHandle) {
                        dos.writeByte(BYTE_STREAM_STATE_HANDLE);
                        ByteStreamStateHandle byteStreamStateHandle = 
(ByteStreamStateHandle) stateHandle;
    +                   dos.writeUTF(byteStreamStateHandle.getHandleName());
    --- End diff --
    
    I think it's OK that we don't change the format version (e.g. to v2) when 
we change the serialization format in a snapshot version right? Since 1.1 the 
version was already updated, which is fine.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to