[ https://issues.apache.org/jira/browse/FLINK-4731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15552302#comment-15552302 ]
ASF GitHub Bot commented on FLINK-4731: --------------------------------------- Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/2584#discussion_r82221108 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FsCheckpointStreamFactory.java --- @@ -219,7 +218,7 @@ public void write(byte[] b, int off, int len) throws IOException { @Override public long getPos() throws IOException { - return outStream == null ? pos : outStream.getPos(); + return pos + (outStream == null ? 0 : outStream.getPos()); --- End diff -- It was buggy before and I think there are in general no tests for this inner class. > HeapKeyedStateBackend restoring broken for scale-in > --------------------------------------------------- > > Key: FLINK-4731 > URL: https://issues.apache.org/jira/browse/FLINK-4731 > Project: Flink > Issue Type: Bug > Components: State Backends, Checkpointing > Reporter: Stefan Richter > Assignee: Stefan Richter > > Restoring the HeapKeyedStateBackend is broken in case that parallelism is > reduced. The restore method is overwriting previously restored state. > We should also add scale-in testing to the RescalingITCase. -- This message was sent by Atlassian JIRA (v6.3.4#6332)