dchristle commented on code in PR #21729:
URL: https://github.com/apache/flink/pull/21729#discussion_r1081619201
##########
flink-python/pyflink/datastream/state_backend.py:
##########
@@ -956,16 +956,20 @@ class PredefinedOptions(Enum):
determined to be beneficial for performance under different settings.
Some of these settings are based on experiments by the Flink community,
some follow
- guides from the RocksDB project.
+ guides from the RocksDB project. Some configurations are enabled
unconditionally (e.g.
+ setUseFsync(false), which disables syncing to storage) so they do not
appear here. See the
+ documentation for the createBaseCommonDBOptions() and
createBaseCommonColumnOptions() methods
Review Comment:
That makes sense. I originally made this change to make PyFlink
documentation match closely to the same description from the Java
documentation, but mentioning the Java classes & non-public methods probably
adds confusion. I made this change in the most recent commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
