dawidwys commented on PR #21594: URL: https://github.com/apache/flink/pull/21594#issuecomment-1400326981
Thanks for the work put into that @jadireddi ! I am not sure if we should proceed with the PR. To be honest I think there is nothing to be done in regards to supporting `TIMESTAMP_LTZ` for avro. The classes you changed are actually deprecated and they should not be used anymore. The new classes that are actually used `AvroRowData(De)serializationSchema` already support `TIMESTAMP_LTZ`. I also verified that the example posted in the JIRA ticket does work. ``` final TableEnvironment tableEnv = TableEnvironment.create(EnvironmentSettings.inStreamingMode()); tableEnv.executeSql( "CREATE TABLE SinkTable(ts TIMESTAMP_LTZ(3)) " + "WITH ('connector' = 'filesystem', 'path' = '/tmp/flink-avro-test', 'format' = 'avro')"); tableEnv.executeSql("INSERT INTO SinkTable VALUES (PROCTIME())"); tableEnv.executeSql("SELECT * FROM SinkTable").print(); ``` If that's the case, I'd be inclined to close the PR and the JIRA ticket. Let me know if I am missing something. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org