[ 
https://issues.apache.org/jira/browse/FLINK-30623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17681300#comment-17681300
 ] 

Dong Lin commented on FLINK-30623:
----------------------------------

It appears that the records/sec of checkpointSingleInput dropped by about 9% 
from 337.5 to 309.4.

My hypothesis for this regression is that most workload of this benchmark is 
related to control flow (e.g. checkpoint-related events) rather than data flow. 
Thus it can not take advantage of the optimization we put in emitNext(...). 
Instead, it suffers the additional overhead of the operation (e.g. checking 
whether mailbox is empty and whether task is available) we put in the 
emitNext(), which leads to the 10% performance regression.

 

> Performance regression in checkpointSingleInput.UNALIGNED on 04.01.2023
> -----------------------------------------------------------------------
>
>                 Key: FLINK-30623
>                 URL: https://issues.apache.org/jira/browse/FLINK-30623
>             Project: Flink
>          Issue Type: Bug
>          Components: Benchmarks, Runtime / Checkpointing
>            Reporter: Martijn Visser
>            Assignee: Rui Fan
>            Priority: Blocker
>              Labels: pull-request-available
>             Fix For: 1.17.0
>
>
> Performance regression
> checkpointSingleInput.UNALIGNED median=338.1445195 recent_median=67.6453005
> checkpointSingleInput.UNALIGNED_1 median=213.230041 recent_median=39.830277
> deployAllTasks.STREAMING median=168.533106 recent_median=159.8534395
> stateBackends.MEMORY median=3229.0248875 recent_median=2985.782919
> tupleKeyBy median=4155.684199 recent_median=3987.5812305
> http://codespeed.dak8s.net:8000/timeline/#/?exe=1&ben=checkpointSingleInput.UNALIGNED&extr=on&quarts=on&equid=off&env=2&revs=200
> http://codespeed.dak8s.net:8000/timeline/#/?exe=1&ben=checkpointSingleInput.UNALIGNED_1&extr=on&quarts=on&equid=off&env=2&revs=200
> http://codespeed.dak8s.net:8000/timeline/#/?exe=8&ben=deployAllTasks.STREAMING&extr=on&quarts=on&equid=off&env=2&revs=200
> http://codespeed.dak8s.net:8000/timeline/#/?exe=6&ben=stateBackends.MEMORY&extr=on&quarts=on&equid=off&env=2&revs=200
> http://codespeed.dak8s.net:8000/timeline/#/?exe=6&ben=tupleKeyBy&extr=on&quarts=on&equid=off&env=2&revs=200



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to