reswqa commented on code in PR #21815:
URL: https://github.com/apache/flink/pull/21815#discussion_r1092842665
##########
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/ResultPartitionTest.java:
##########
@@ -399,6 +399,10 @@ void testIdleAndBackPressuredTime() throws IOException,
InterruptedException {
while (!isInBlockingBufferRequest(requestThread.getStackTrace())) {
Thread.sleep(50);
}
+ // there is an extreme case where the request thread recovers from
blocking very
+ // quickly, resulting in a calculated back-pressure time is equal to
0. This is used to
+ // avoid this case.
+ Thread.sleep(5);
Review Comment:
We can also change `isGreaterThan(0)` to `isGreaterThanOrEqualTo(0)`, but
this seems to break our original intention of test the back pressure time is
not zero.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
