Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2577
Thanks for the pr @zentol. Looks good to me! A couple of things I noticed:
- The prefix of the interfaces (`Access*`) could be a bit confusing. What
about these?
- interface: `ExecutionGraph`
- runtime:`RuntimeExecutionGraph`
- archive: `ArchivedExecutionGraph`
That said, you probably chose to not rename the existing `ExecutionGraph`
class to minimize changes.
- How about having an interface `Archiveable<T extends Serializable>`
containing the `T archive()` method? This interface could be implemented by all
runtime classes which are archievable.
- You chose not to port the `ExecutionConfig` or `ExecutionConfigSummary`
to your changes while rebasing?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
