lindong28 commented on code in PR #201: URL: https://github.com/apache/flink-ml/pull/201#discussion_r1093098101
########## flink-ml-python/docs/reference/pyflink.ml.core/api.rst: ########## @@ -0,0 +1,92 @@ +.. ################################################################################ + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. + ################################################################################ + +======== +Core API +======== + +Stage +----- + +Base class for a node in a :class:`Pipeline` or :class:`Graph`. The interface is only a concept, +and does not have any actual functionality. Its subclasses could be :class:`Estimator`, :class:`Model`, +:class:`Transformer` or :class:`AlgoOperator`. No other classes should inherit this interface directly. + +Each stage is with parameters, and requires a public empty constructor for restoration. + +.. currentmodule:: pyflink.ml.core.api Review Comment: It seems that the module of this class is inconsistent with the package of the `Stage` class in Flink ML Java library. I discussed with @HuangXingBo offline and we agreed to update pyflink-ml to use the same package path as Java library. And I created FLINK-30865 to track this issue. Can you help fix FLINK-30865 and then update the module path here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
